feat(web-console): search across multiple tabs #459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itor memory leaks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive search functionality that enables users to search across multiple tabs, including both active and archived ones. The search results are displayed in a dedicated "Search Panel" on the left side, alongside the existing data sources panel.
- Adds a cross-tab search mechanism with support for case-sensitive, whole word, and regex search options
- Introduces temporary buffer functionality for previewing closed tabs without permanently reopening them
- Integrates a global keyboard shortcut (Ctrl/Cmd + Shift + F) to open the search panel
Reviewed Changes
Copilot reviewed 48 out of 49 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-console/src/utils/textSearch.ts | Core search engine with web worker support for performance |
| packages/web-console/src/services/search.ts | Search service orchestrating buffer searching and result aggregation |
| packages/web-console/src/scenes/Search/ | Complete search UI components including panel and results display |
| packages/web-console/src/providers/SearchProvider/ | Context provider managing search panel state and keyboard shortcuts |
| packages/web-console/src/providers/EditorProvider/ | Enhanced with temporary buffer support and search integration |
| packages/web-console/src/scenes/Console/index.tsx | Updated layout to support dual left panels (data sources and search) |
| packages/web-console/src/store/ | Database schema updates and buffer management enhancements |
Comments suppressed due to low confidence (1)
packages/web-console/src/scenes/Search/SearchPanel.tsx:275
- The condition
keys.length === 0 && keys[0] === 'value'will always be false because if keys.length is 0, then keys[0] will be undefined. This logic appears incorrect.
}
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
bluestreak01
previously approved these changes
Aug 18, 2025
bluestreak01
approved these changes
Aug 18, 2025
Vaibhav91one
pushed a commit
to Vaibhav91one/ui
that referenced
this pull request
Oct 28, 2025
* feat(web-console): search across multiple tabs * submodule * fix monaco imports * left panel state updates * make shortcut work on both mac & !mac * add search tests & use custom search * submodule * search options test case & corrections * submodule & navigation limit in test * prevent page load race conditions and suggestion selection in editor * don't clear local storage before clearing warnings * cleanup * search in tab names * submodule * handle invalid regexes * submodule * search test fix * editor focus & query param processing fixes * address ai reviews :) * partial updates on search results, use web workers for search, fix editor memory leaks * Update packages/web-console/src/providers/EditorProvider/index.tsx Co-authored-by: Copilot <[email protected]> * Update packages/web-console/src/utils/textSearch.ts Co-authored-by: Copilot <[email protected]> * avoid bundling name loss on worker definition * temp buffer navigation fix, search in lines * bumped questdb to master --------- Co-authored-by: Vlad Ilyushchenko <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Vlad Ilyushchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ctrl/Cmd + Shift + Fwill now open the search panel.